Php API Bug - PHP Warning when no data returned due to requesting Last Modified data

Php API Bug - PHP Warning when no data returned due to requesting Last Modified data

If no records are returned due to the If-Modified-Since header, the PHP API doesn't handle it correctly

In the example below, assume $m is a module:

  2. // Get records from the future!
  3. $ims = (new \DateTimeImmutable())->add(new \DateInterval('P1D'))->format("Y-m-d\TH:i:s+00:00");
  4. try {
  5. $mdata = $m->getRecords(null, null, null, null, null, ['if-modified-since' => $ims ])->getData();
  6. } catch (\Exception $e) {
  7. if ($e->getMessage() == "No Content") {
  8. $mdata = [];
  9. } else {
  10. throw $e;
  11. }
  12. }
  13. print count($mdata)." rows returned for module $mname\n";

As no data is being returned, the  $responseJSON["data"] is a bool, and you can' foreach over them, leading to this warning:

Warning: Invalid argument supplied for foreach() in /var/www/app/vendor/zohocrm/php-sdk/src/com/zoho/crm/library/api/handler/MassEntityAPIHandler.php on line 324

This can be fixed backend by actually returning an empty array, or by the frontend checking if something is an array before foreaching over it.